Fix possible buffer overflow in ClpSimplexOther
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix super build (e.g. FetchContent) integration - cmake: option() honors normal variables (CMP0077)
Mart-Bogdan
force-pushed
the
stable/1.17
branch
from
07ab323
to
6138e74
Compare
Mart-Bogdan
changed the title
ClpSimplexOther::parametricsClpSimplexOther
Mart-Bogdan
force-pushed
the
stable/1.17
branch
from
6138e74
to
0b3c287
Compare
|
P.S. I've noticed this warning when was trying to build https://github.com/google/or-tools |
|
To be sure, is it the backport of: ps: thx for contributing to FOSS ! |
|
Yes, it's same fix applied to multiple reps. I initially noticed warning about that when was building coin-or from google's repo. And your repo was used directly. So decided to post it here as well. IDK if upstream would accept patch soon. |
|
and this line was added, as same fix is in using second variable. as "POSIX standard forbids strings to overlap." |
Mizux
force-pushed
the
stable/1.17
branch
3 times, most recently
from
7c9fbcf
to
37a4f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this as warning from GCC when was installing some packages from AUR.
There is possibility of buffer overflow, especially in this case:
Because we are using content of array
lineinside template, and it can be 199 chars already.